-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding four arithmetic functions #70
Open
reinermartin
wants to merge
12
commits into
JuliaMath:main
Choose a base branch
from
reinermartin:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Primes.totient
Added `moebiusmu` with two signatures (integers and factorizations as inputs), and added docstring
Added tests for moebius(), liouville(), divisorcount(), divisorsum()
I don't know how (technically) I can resolve this trivial conflict in api.md (the version where the 4 new functions are present is the valid one). Am I even allowed to do it? Help! |
I'd also like to have this (esp. the Möbius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added 4 functions:
moebius
,liouville
,divisorcount
, anddivisorsum
. They are all multiplicative in the sense thatf(n m) = f(n) f(m)
ifn
andm
are relative prime, and they can easily be computed from the prime factorization (see https://en.wikipedia.org/wiki/Arithmetic_function#Multiplicative_functions). Documentation and tests are included.This is functionality for which a system like Mathematica has been useful in the past, but it would be good to have it in Julia. I plan to add more such functions and more detailed documentation later.